Jump to content


Photo

Text bugs


  • Please log in to reply
4 replies to this topic

#1 Spider

Spider

    DEC (HL)

  • Administrator
  • 2,567 posts

Posted 03 August 2017 - 12:32 PM

Well if you would call them that. :)
 
First of all let us ignore room names that are not centred properly aka "Halfway up the East Wall" and "A bit of tree" amongst a few others are both too far leftwards. A few are too far rightwards too.
 
Of room names though:
 
1. Room 51 / #33 "Tool  Shed" has two spaces between the words instead of one.
2. Room 54 / #36 "West  Wing" has two spaces between the words instead of one.
 
When I looked again at the keypad 'bright vs not bright' issue (see here if needed) for something unrelated it brought my attention to the code wording itself. Lets take a closer look, ignore the fact the code is showing "--" this is simply so the same one is shown for each screenshot to keep it simple:
 
"Enter Code at grid location"
 
key1.png
 
"Sorry, try code at location"
 
key2.png
 
Notice "code" is capitalised on the first but not the second. I'm not 100% sure which is grammatically correct though.

 

Not shown in screenshots however to 'fix' this either way:

 

POKE 34193 , 99 (#8591#63) to change the "C" in the first message to a lower-case "c" or to go the other way instead POKE 34230 , 67 (#85B6 , #43) to change the "c" in the second message to an upper-case "C"

 
Also, look at the screenshots here, there is a potential spacing issue too. :) Note that the code entry ID requested has a space between itself and the end of the screen but the text is set to the far left. Either something like a colon needs adding...
 
key1_colon.png key2_colon.png
 
To do this: POKE 34214 , 58 (#85A6 , #3A) for the first message and POKE 34246 , 58 (#85C6 , #3A) for the second.
 
... perhaps a simpler, tidier fix is to just move the text along one character instead to make it sit 'neatly' instead. I think I prefer this method:
 
key1_moved.png key2_moved.png
 
To do this: POKE 34500 , 1 (#86C4 , #01)
 
This changes the LD DE, 18432 to LD DE, 18433 (#4800 to #4801) which the display file address to display the message, in Basic its "PRINT AT 8,0 vs PRINT AT 8,1"
 
In theory the length specified that follows that: LD C,32 (#20) reducing down to 31 (#1F) to prevent overspill onto the next line however this is not essential as its not 'seen' and the last few characters are blank in the message so you are only printing a blank character (ascii 32 / #20) onto a blank space aka: no effect. The length could be reduced by a few characters even with no other changes as the last character blocks on that line are overwritten by the code specified to input anyway.


Changing order to chaos since 1984

#2 IRF

IRF

    Advanced Member

  • Contributor
  • 2,909 posts

Posted 03 August 2017 - 12:39 PM

I think the 'c' should be lower case, or else the 'G' and 'L' from 'Grid Location' should be upper case for consistency.



#3 Spider

Spider

    DEC (HL)

  • Administrator
  • 2,567 posts

Posted 03 August 2017 - 01:16 PM

I think the 'c' should be lower case, or else the 'G' and 'L' from 'Grid Location' should be upper case for consistency.

I've added the POKES to change 'code' vs 'Code' now either way. :)


Changing order to chaos since 1984

#4 Metalmickey

Metalmickey

    Advanced Member

  • Contributor
  • 256 posts

Posted 13 September 2017 - 09:59 PM

i'm in the middle of re-doing my 'As manufacturer probably intended' project following an experiment that didn't quite go to plan .. i might put this in  :P


Edited by Metalmickey, 13 September 2017 - 10:00 PM.


#5 IRF

IRF

    Advanced Member

  • Contributor
  • 2,909 posts

Posted 13 September 2017 - 10:25 PM

I think the 'c' should be lower case, or else the 'G' and 'L' from 'Grid Location' should be upper case for consistency.

 

The former would be more consistent with the 'second attempt' message.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users