25 replies to this topic

[Norman Sword]

I have uploaded the Demo version of JSW 128 VL5.tap The slight name change is to JSW VL5 demo.tap. This is up loaded as a revision of JSW128 vl5.tap

This demonstrates a very very very fast version of Jet set willy.

This version also now plays music and not blips for the in game music. The tempo of the music is adjusted as the games speed is changed.. Since the basic music note is played twice, it was not possible to do step-less adjustment, for the faster versions. 

A large amount of extra graphics and routines added. All the graphics are displayed bit by bit in the extra title screens added. (over 21 variations on the title screen- based on the main five )

To see full speed, turn off the music. 

Since the option to upload is here (as well) I will attach the file here.

 

-----------------------

One note changed. Typing error.

The tune routine like most things was changed and speeded up. This meant all music data needed to go through a translation table to adjust its speed. The data had a misplaced digit. The note was only played once. 

----------------------

I will attach the last version here (19th January 2019)


JSW VL5 DEMO revision 3b.tap




--------------------------------------------------

All the main screens. 
 

Attached Thumbnails

• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 

Attached Files

•  JSW VL5 DEMO revision3b.tap   40.6KB   4 downloads

Edited by Norman Sword, 26 January 2019 - 07:53 AM.

[IRF]

I like the way that the portals animate - the top and bottom rows like conveyors, but the sides also 'rotate vertically', requiring a lot more than just the RL and RR commands.

 

There is a flat note (or consecutive pair of notes) in the 'Rich Man' in-game tune - just after half way through, there is an A# [byte value #48 according to Richard Hallas's tone chart] which used to be a B [#44] in the original game.

Edited by IRF, 01 January 2019 - 01:11 PM.

[Norman Sword]

Noted the one note... Duly changed. I tend to not listen to the music. And I normally have no sound output on my PC.

Others in the room do not appreciate the sound playing.

[IRF]

The first note of the in-game tune is skipped when you first fire up the game.  (i.e. The "If" of the line "If I were a rich man".)
 
I suspect that this occurs because the music note index (initialised to zero during the Title Screen routine) is incremented within the Main Loop before the indexed note is played during that pass through the Main Loop.
 
This also happens in the original JSW (and MM):
http://skoolkid.gith...html#missedNote
 
However, it is more noticeable here:
 
- In the original games, each note is played twice (i.e. there are two 'blips' of the same pitch, and of a fixed length), and so skipping the 'first' note in reality just means skipping the first 'blip' of the first note;
 
- Whereas in your rewrite, I gather that you have optimised the memory taken up by the tune data - by playing one note for a longer period, rather than having several consecutive notes of the same pitch?  This has the effect that when the first note is skipped (presumably by the same process outlined in the Skoolkid link above), it is equivalent to skipping both 'blips' of the first note of the tune in the original JSW game engine.
 
**
 
By the way, the increased speed at which your latest rewrite of the game runs is very impressive!

Edited by IRF, 10 January 2019 - 03:54 PM.

[Norman Sword]

The way this plays music bears little resemblance to the way Matthew played music. His was just an incremented pointer, playing at a fixed rate. Code wise :-

35648 LD A,(34273) Increment the in-game music note index at 34273
35651 INC A
35652 LD (34273),A
35655 AND 126 Point HL at the appropriate entry in the tune data table at 34399
35657 RRCA
35658 LD E,A
35659 LD D,0
35661 LD HL,34399
35664 ADD HL,DE

at this point (hl) holds the note data
"BC" will be set with a fixed value of 3

and my code --- minus most of the comments and data

; this plays variable length and variable note repeat and even mutes the music if needed

the call to STEP_INDEX- this adds "A" to "HL" and returns  the contents of "(HL)" :  A=(A+HL)

 

The routine below plays the in game music, changed from just being a variable delay.

snail_run:
    ld hl,var_flag ; this is the speed factor
    LD  a,(MUSIC) ; the music flag (on/off)
    bit 1,a
    ld a,(hl)
    LD D,0
    jr Nz,set1_version
    add a,4
    LD  D,#18
set1_version:
    or a
    ret z 
; this loop is repeated less than 20 times at maximum slow down
;(the speed to execute this code compared to the delay this is calculating, means it is insignificant)
; on a flat out game (music off and fastest speed) this code is not executed.
    ld e,a
    ld bc,$190 ; a delay value
    ld hl,0
sgk:
    add hl,bc  
    dec a
    jr nz,sgk
    ld c,l
    ld b,h   
    ld hl,repeating_note ; table of Blip values (how many times the note will blip)
    ld a,e
    call STEP_INDEX 
    LD E,A
S_M_C_RECHARGE:  EQU $+1
    ld a,2   
    dec a
    jr nz,se1_note
    inc (hl) 
    ld a,E
se1_note:
    ld (S_M_C_RECHARGE),a 
    ld a,(hl)
    and 63 
    LD HL,Music_data ; table of note data
    CALL STEP_INDEX
    ld e,a

E= note
BC= duration
L= mic toggle
D=mic toggle (the routine uses "L", so this must be copied, somewhere)

Note standard in all my code. if something starts with S_M_C_ it is indicating the value or variable is part of inline code that will be modified e.g. Self Modifying Code

;--------------------------------------------

The game notes are still played as designated minimum of two blips per note, However on the first pass the blip count is set to two and is similar to the problem in the original JSW. This is decremented and the first blip is played. This is one blip before the note index is moved to the next note.
 

On first game start up the speed index is set to very fast and in this instance the number of blips is set to 5 for all the subsequent notes and the blip counter should be set at 5 (or even 6) . Not as stated above at 2. 
 

Playing one blip is equivalent at the game start to playing 1/5 of a note, Which is more noticeable than the equivalent problem in the original. All the changes in speed reset the blip count after each note. The routine has no external counters and does not get updated outside of the music/delay routine. The note index is reset on each game.
 

The technical problem is the blip count, which was not reset and due historically to this being a two blip game was left as 2 (which would have still omitted the first half of the note, even if the game was started at the slowest speed). I thought it would take too much code to actually adjust the blip counter at reset to the required value on a game reset (I knew it was a problem- just was not bothered, to actually fix it--- this does have a great big banner on it saying DEMO of speed)
 

addendum to the paragraph above......( on subsequent slow speed game, playing, with 2 blips per note) Not resetting the blip count can make it either skip one blip on subsequent game resets or skip the whole note. The chances are 50-50

I have now fixed this problem and inserted a blip reset, and changed the note index to the last note. This ensures on the first pass the blip count is reset to the correct value for its speed, and the note is stepped to the next note, which will be the first note. This was done by changing  the data in a data reset list from (NOTE_INDEX ,0) to (NOTE_INDEX ,63) and inserting 2 more values (S_M_C_RECHARGE , 1). The modification was far easier than I thought at the time of writing the original. 

-------------------------

As I mentioned before I do not listen to the music, it is turned off. If the game had crashed or started playing very obvious long note sequences.I might have checked it a bit more or at least bothered to investigate how I could reset the data. It played and it was not the focus of what I was doing.

Edited by Norman Sword, 26 January 2019 - 07:55 AM.

[IRF]

Thanks for the explanation Norman!

 

One other little thing that I noticed (if I recall correctly) is that when the game is running at its fastest speed (and possibly at other speeds), the dancing lives on the status bar no longer keep in time with the music?  (Unless your latest amendment has had the additional effect of correcting that; I haven't had chance to check it out yet.)

Edited by IRF, 10 January 2019 - 06:05 PM.

[Norman Sword]

The dancing was based on the games Ticker. This quick update--- updates from the games current playing note index. 

This keeps his dancing at a more fixed speed (in tempo to the music)

Now with a file actually attached:-

--------------------------------------------------------

Addendum a couple of hours is a long time:- 

 jsw VL5 DEMO revision3.tap
The animation is based on the tempo of the music, and is too Manic (right frame of mind but wrong game). I could slow it down to look less Manic. (Tried it and was still not happy.) 

jsw VL5 DEMO revision3a.tap
The animation in this version is based instead on the note being played. So if a note is sustained, the animation will not change. The sequencing of the animation  is solely dependent on the value of the note played. So the animation is fixed by the music. I feel this whilst erratic frantic (not Manic) better suits the game.

Alas I am out of memory so the next addition I did corrupted a pile of data. Some visual screen data is deliberately placed at the end of available space, and if I exceed my code space. The data will be displayed on the screen as a mess. this indicates visually to me the limits of editing.
Whilst I had to delete this routine the idea was to actually play the wording of the tune across the bottom of the screen as Willy danced -- Looked interesting, just not interesting enough to accommodate into the space available. Something would need to be deleted and the routine was not exciting enough to progress any further.




 

Edited by Norman Sword, 26 January 2019 - 07:55 AM.

[Norman Sword]

The speed changes
 

The biggest factor in overall game speed is the four innocent looking LDIR instructions that copy the screens.

Those four ldir's move 9216 bytes of memory

mentioned numerous times:-

using ldir takes 21*9216 T states to copy the screens on each and every loop. A very big chunk of time.

Using LDI takes 16*9216 T states to copy the screen on each and every loop (idealized times) . A noticeable increase in speed.

Using stack copy can push the idealized times up to  11*9216 T states, a very noticable increase in speed.

At this point in speed increase we can make more and more changes in the games background speed, but we have hit a basic speed limit. The screen copies dwarf all other speed considerations.

There is however another factor that is adding a major slow down. One that is not looked at because the normal scope of editing does not bring into its remit the placement of the copy screens. ALL the copy screens sit below #8000 and this means all the screen data is written to contended memory. And all the copies to and fro are copies that are in contended memory. Every single sprite draw and screen copy is affected by the contended memory issue and this speed decrease is not within the scope of editing JSW.
 

The small program included here, just loops and draws to a dummy screen (filling it with data). it then copies the dummy screen to another dummy screen. And finally copies the 2nd dummy screen to the visible screen.(similar to the game copy routines in JSW)  Each loop of fill and double copy, moves a visible pointer on the screen, and a text line displays what memory is being copied.

The small routine does this copying using two sets of screens. The first set of screens is sat below #8000 and all the data is moved from contended memory to contended memory (which is how JSW is set up). The 2nd routine uses the same routine, but now the two copy screens are sat above #8000. This moves the same amount of data and it is only the final copy that is moving data into contended memory. (the copy to the visible screen)

What this small program shows is the speed decrease that contended memory gives

a 256 loop of this routine in contended memory 26.73 seconds
a 256 loop of this routine in high memory 23.13 seconds
 

A slowing down due to contended memory of 3.6 seconds.

The contended memory issues show that a speed increase of around 14% is available on LDIR just by moving the screens. Not a great deal of time on its own, but once the screens are moved. That 14% increase is mirrored by all the other methods of screen copy. A stack copy using un-contended memory is a lot faster than the same stack copy with contended memory.

So in the JSW GAMES version VK and version VL. I use un-contended memory for the copy screens. From version VK  and onward the whole game allocation is changed. And no amount of editing the basic game will achieve these speed increases, until they are also reconfigured in a similar way (or rewritten)

Vesion VL DEMO goes one stage  further and uses a change of strategy. This adds a great deal of code and complexity, but the result is evident in the speed increase.

 

Attached Files

•  CONTEN~1.tap   329bytes   4 downloads

[IRF]

I think I read somewhere about using a XOR method for updating moving sprites (to erase the old one and add the new one), so that instead of having to copy the whole screen twice, you only had to update the parts that had changed since the last pass through the Main Loop, and that can help to speed things up?

[IRF]

Addendum a couple of hours is a long time:- 

 jsw VL5 DEMO revision3.tap
The animation is based on the tempo of the music, and is too Manic (right frame of mind but wrong game). I could slow it down to look less Manic. (Tried it and was still not happy.) 

jsw VL5 DEMO revision3a.tap
The animation in this version is based instead on the note being played. So if a note is sustained, the animation will not change. The sequencing of the animation  is solely dependent on the value of the note played. So the animation is fixed by the music. I feel this whilst erratic (not Manic) better suits the game.

 
That (rev3a dancing) looks really cool!
 
 

Alas I am out of memory so the next addition I did corrupted a pile of data. Some visual screen data is deliberately placed at the end of available space, and if I exceed my code space. The data will be displayed on the screen as a mess. this indicates visually to me the limits of editing.

Whilst I had to delete this routine the idea was to actually play the wording of the tune across the bottom of the screen as Willy danced -- Looked interesting, just not interesting enough to accommodate into the space available. Something would need to be deleted and the routine was not exciting enough to progress any further.

 

 
Do you mean the lyrics to the song?  That's another great idea!  The only drawback is that whoever wrote "Rich Man" just filled in half of the song with "diddle diddle dums", I'm not sure it would be worth going to the effort, for a song where the composer didn't make an effort to fill in all the words!

Edited by IRF, 25 January 2019 - 02:25 PM.