Jump to content
Jet Set Willy & Manic Miner Community

SkoolKid

Contributor
  • Posts

    54
  • Joined

  • Last visited

About SkoolKid

Profile Information

  • Gender
    Not Telling

Recent Profile Visitors

3,593 profile views

SkoolKid's Achievements

Advanced Member

Advanced Member (3/3)

73

Reputation

  1. I have, and the answer is no, it doesn't.
  2. Can't say I have - time to update my JSW disassembly TODO list. :) By the way, I checked and this is the only instance of a non-conveyor tile being affected by the Cell-Graphics bug.
  3. SkoolKid

    Sources

    One advantage of generating an ASM file from the SkoolKit source files is that it retains all the annotations. You can also generate an ASM file that includes several bugfixes: skool2asm.py -f 2 jsw.skool > jsw-bugfixes.asm
  4. SkoolKid

    Sources

    Yes, you can generate an assembler-friendly ASM file from the SkoolKit source files for MM or JSW. In fact, that's one of the main points of SkoolKit - you can use the same source files to generate both the HTML disassembly and an ASM file. You will need to download SkoolKit - for which you'll also need Python, version 3.4 or later - and use skool2asm.py to convert jsw.skool into jsw.asm (for example): skool2asm.py jsw.skool > jsw.asm I've successfully tested the output of skool2asm.py with pasmo, SjASMPlus and z80asm (the assembler that comes with z88dk), but it might work with other assemblers too.
  5. No, there's particular reason to use XOR instead of OR here. As you've noted, there's no difference in the resulting value in the A register, and there's also no difference in the effect on the flags (which are not checked anyway).
  6. This bug just got more interesting! :) I think I know why Willy is relocated further down the rope on your first attempt: in the section of code that handles Willy's movement along the rope, the rope status indicator is reset to 12 if it's found to be 11 or less. How you then manage to circumvent that code in your second attempt, I have no idea yet.
  7. Oh, I know that - what I meant was that they are erroneously skipped by my cavern-drawing code. I don't know if I've mentioned this before, but none of the images in my disassemblies are derived from in-game screenshots - they are all programmatically generated.
  8. As far as I know, the printer buffer (5B00-5BFF) is used only by the stack - the stack pointer being 5C00 when the game starts. Regarding the cyan guardians in the Kong Beast caverns: well, well, well! My first thought is that because the third horizontal guardian in those caverns is unused, the fourth one (the cyan one) is erroneously skipped. I will look into it... Regarding the comment at 91EE: the comment at the beginning of that section of code (at 91A3) says "The Kong Beast is falling", but I suppose you might have forgotten that by the time you reach 91EE. :)
  9. Just checking in to acknowledge the comments and see what new stuff I should be adding to my MM/JSW disassembly TODO lists! :) I've been preoccupied recently with SkoolKit 5.3 and the Spectrum ROM Disassembly, but I'm going to take a break from those and concentrate on MM and JSW for a bit. Now, where were we the last time I was here...
  10. But this implies that the first pair of offsets at 8300/8380 are not used, and that the pair at 8356/83D6 are used. You see my confusion? I need to (re)examine the code closely at some point to figure out what's going on.
  11. So why should the text read "from F to F+32" (33 offsets) instead of "from F to F+31" (32 offsets)?
  12. I'm really confused now! Let me put the questions another way. 1. How many pairs of x- and y-offsets are used to draw the rope during each animation frame: 32 or 33? 2. Is the pair of offsets at 8300/8380 used? 3. Is the pair of offsets at 8356/83D6 used?
  13. Isn't that a contradiction? If only segments 1-33 have x- and y-offsets applied to them, and the bytes at 8300/8380 are used for segment 1, then the bytes at 8356/83D6 are unused - and the text as it stands now is correct: entries from F to F+31 inclusive.
  14. In which case the zero bytes at 8356 and 83D6 - currently marked as unused - are in fact used. Which also means that when the rope is the leftmost or rightmost extent of its swing, the last segment is not drawn in the correct place (the bytes at 8356 and 83D6 should probably be 3 and 4 respectively). Which is a bug. Is this actually the case? Investigation needed!
  15. No, not at all - keep them coming! I want the disassemblies to be as accurate and comprehensive as possible, and I'm always happy to receive new trivia suggestions and bug reports.
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.